Allow usage of backgrounds in template #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check always failed, because the value within pdf is already a string for the pdf and the value compared to is a set of three values in rgb colorspace.
The template elements rect and text allow the setting of fill, which fills the rectangle or the background of the text in the color defined for 'background'
|
You may want to submit this PR against fpdf2, an actively maintained fork of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits allow the usage of background in template elements (rect and text) together with the 'fill' attribute set.
Additionally some checks are removed that will always fail due tu the representation of the colors inside fpdf.